Fix force loading of libreforge.jar multiple times #170
Conversation
|
You can already just put a libreforge jar into your plugins folder and it auto-loads that version, without needing to patch each plugin |
Yeah, but as soon as you put 2 of them into your server it dies. It tries to load that libreforge.jar multiple times and crashes. You can see for yourself if you try it out or just check the other method that loads the highest libreforge version. That method also has this exact same line for the same reason. |
|
I didn't try just dumping into the root plugins folder, since it very much looked like I should put it into the plugins/libreforge/versions folder where every other version lives. This PR fixes that. Your workaround might work, but if this is the intended way to load a custom version, then this one line couldn't hurt imo. |
At present, nobody can really use custom libreforge forks with multiple eco plugins. This PR fixes this issue by preventing the eco plugins from force-loading libreforge multiple times.
Use case
I would like to disable/improve a lot of holder updates and make changes to the other eco plugins as well to optimize the hell out of them and remove the refreshes I don't need, or to make the entire effect system semi async maybe. I need to test it with almost every eco plugin if I ever want to merge this back (though I highly doubt you would accept something like this).
Will be much easier if this would just work and I wouldn't need to patch every eco plugin individually, to properly force load custom versions of libreforge.